Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherrypick-2.0: ui: Custom Graph Debug Page #23227

Merged
merged 2 commits into from Feb 28, 2018

Conversation

mrtracy
Copy link
Contributor

@mrtracy mrtracy commented Feb 28, 2018

Two commits

  • A small update to LineGraph to support graphs without line-related hover events
  • The custom graph debug page

Adds a debug page which allows users to create a "custom" graph,
displaying any combination of metrics they wish. The currently selected
metrics are stored in the URL, so graphs can be shared by copying the
link.

screen shot 2018-02-27 at 4 18 26 pm

Matt Tracy added 2 commits February 28, 2018 13:36
Instantiating a graph without these options was causing numerous
rendering issues.

Release note: None
Adds a debug page which allows users to create a "custom" graph,
displaying any combination of metrics they wish. The currently selected
metrics are stored in the URL, so graphs can be shared by copying the
link.
@mrtracy mrtracy requested review from vilterp and a team February 28, 2018 18:46
@mrtracy mrtracy requested a review from a team as a code owner February 28, 2018 18:46
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@mrtracy mrtracy merged commit 9a03071 into cockroachdb:release-2.0 Feb 28, 2018
@mrtracy mrtracy deleted the mtracy/cherrypick_23070 branch February 28, 2018 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants