sql: improve TestTxnObeysTableModificationTime #23681
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
vivekmenezes
commented
Mar 9, 2018
| t.Fatal(err) | ||
| } | ||
|
|
||
| // Insert an entry so that the transaction is guaranteed to be | ||
| // assigned a timestamp. |
There was a problem hiding this comment.
this is no longer needed because transaction timestamps are assigned during BEGIN
pkg/sql/lease_test.go
Outdated
| t.Fatal(err) | ||
| } | ||
|
|
||
| if err := tx.Commit(); !testutils.IsError(err, "transaction deadline exceeded") { | ||
| if err := txWrite.Commit(); !testutils.IsError(err, "TransactionStatusError: transaction deadline exceeded") { |
There was a problem hiding this comment.
good example of why this ought to be retryable
vivekmenezes
force-pushed
the
insertalter
branch
3 times, most recently
from
8a97976
to
beef95a
Compare
removes the use of SNAPSHOT ISOLATION in the test. Tests read-only, write-only, and read-write transaction scenarios. Release note: None
vivekmenezes
force-pushed
the
insertalter
branch
from
beef95a
to
7cbea6c
Compare
|
Since @vivekmenezes is out of the office I'm going to incorporate this into #27040. Review status: Comments from Reviewable |
complete! 0 of 0 LGTMs obtained (and 1 stale)
|
@vivekmenezes there were requests for more docs in #27040, if you're so inclined. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removes the use of SNAPSHOT ISOLATION in the test.
Tests read-only, write-only, and read-write transaction
scenarios.
Release note: None