libroach: automatically compact files with too many range deletions #24057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release note: None
|
This change is |
|
Looks good, but let's see if we can get a response from upstream first before we start making changes like this ourselves (especially if it doesn't fix the whole problem) Review status: 0 of 2 files reviewed at latest revision, all discussions resolved, all commit checks successful. Comments from Reviewable |
|
Yeah, it doesn't come close to fully fixing the problem. The compactions can take quite a while to finish, and I haven't convinced myself that the bottommost compactions are even happening. |
|
This has been taken over by Peter in #31975. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This anecdotally improves the situation in #24029 just a bit. The cluster still gets bricked, but there's hope of recovery without manually running
./cockroachdb debug compact, because RocksDB will automatically schedule a compaction for any SST with more than a few range deletion tombstones.Mostly just a proof-of-concept.
Release note: None