build: don't strip release binaries #24296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stop stripping release binaries. This nearly doubles their size (55MiB -> 110MiB), but it makes backtraces and pprof profiles substantially more useful. Note that we currently build our C/C++ dependencies with `-g1`, which is enough debug information for symbolized backtraces but not enough debug information to fully support a debugger (e.g. local variable information). Release note (build note): Release binaries are now built with enough debug information to produce useful CPU profiles and backtraces.
|
This change is |
bdarnell
approved these changes
Mar 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop stripping release binaries. This nearly doubles their size (55MiB
-> 110MiB), but it makes backtraces and pprof profiles substantially
more useful.
Note that we currently build our C/C++ dependencies with
-g1, which isenough debug information for symbolized backtraces but not enough debug
information to fully support a debugger (e.g. local variable
information).
Release note (build note): Release binaries are now built with enough
debug information to produce useful CPU profiles and backtraces.