cli: Truncate haproxy.cfg file before overwriting it #24332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes cockroachdb#24330 Release note (cli change,bug fix): If an haproxy.cfg file already exists in the current directory when `gen haproxy` is run, it now gets fully overwritten instead of potentially resulting in an unusable config.
|
This change is |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24330
Release note (cli change,bug fix): If an haproxy.cfg file already exists
in the current directory when
gen haproxyis run, it now gets fullyoverwritten instead of potentially resulting in an unusable config.
Candidate for cherry-picking. To v2.0.1, if not v2.0.0 (@bdarnell).