backport-2.0: sql: fill in required privileges at Validate time. #24393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes cockroachdb#24382 We now call MaybeFixPrivileges directly in Validate to avoid any cases of missed descriptors (occurring in mixed-versions settings). This can be removed once 2.1 has a repeated migration to fix privileges, in which case mixed-version will be 2.0 and generate good descriptors anyway. We may even want to wait until 2.2 if we want guarantees that noone can fail validation while migrations are running. This needs to be cherry-picked into 2.0 as this affects rolling upgrades. Release note: sql change: always fill in minimum required privileges.
|
This change is |
|
@bdarnell: this one definitely needs to be a 2.0 cherry-pick, sorry. |
benesch
approved these changes
Apr 1, 2018
|
Let's start testing the new build today so this change can be included in rc1 tomorrow. Review status: 0 of 4 files reviewed at latest revision, all discussions resolved, all commit checks successful. Comments from Reviewable |
|
Thanks for the review. Who is in charge of it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #24390.
/cc @cockroachdb/release
Fixes #24382
We now call MaybeFixPrivileges directly in Validate to avoid any cases
of missed descriptors (occurring in mixed-versions settings).
This can be removed once 2.1 has a repeated migration to fix privileges,
in which case mixed-version will be 2.0 and generate good descriptors
anyway.
We may even want to wait until 2.2 if we want guarantees that noone can
fail validation while migrations are running.
This needs to be cherry-picked into 2.0 as this affects rolling
upgrades.
Release note: sql change: always fill in minimum required privileges.