cherrypick-1.1: sql: fix ALTER INDEX RENAME on primary index #24779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
knz
force-pushed
the
20180413-cherrypick-rename-pk
branch
from
96c1ea4
to
d28983e
Compare
|
Review status: 0 of 3 files reviewed at latest revision, all discussions resolved. pkg/sql/logictest/testdata/logic_test/rename_index, line 97 at r1 (raw file):
Ideally this test would verify that the statement has the desired effect, not just that it doesn't crash. Comments from Reviewable |
ALTER INDEX ... RENAME would crash if issued on the primary index. Release note (bug fix): `ALTER INDEX ... RENAME` can now be used on the primary index.
knz
force-pushed
the
20180413-cherrypick-rename-pk
branch
from
d28983e
to
49b2637
Compare
|
Review status: 0 of 3 files reviewed at latest revision, 1 unresolved discussion. pkg/sql/logictest/testdata/logic_test/rename_index, line 97 at r1 (raw file): Previously, bdarnell (Ben Darnell) wrote…
Done. I'll forward-port the additional test to the latest code. Comments from Reviewable |
|
bors r+ |
Build succeeded |
craig bot
pushed a commit
that referenced
this pull request
Apr 18, 2018
24899: sql: add a missing test for ALTER INDEX RENAME r=knz a=knz Requested by @bdarnell in #24779 (comment). Release note: None 24910: docs: Update show_ranges_stmt diagram r=rmloveland a=rmloveland Release note: None Co-authored-by: Raphael 'kena' Poss <knz@cockroachlabs.com> Co-authored-by: Rich Loveland <rich@cockroachlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picks #24776.
cc @cockroachdb/release