Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cherrypick-2.0: sql: report unimplemented error on ORDER BY in function arguments #25147

Merged
merged 1 commit into from Jul 20, 2018
Merged

cherrypick-2.0: sql: report unimplemented error on ORDER BY in function arguments #25147

merged 1 commit into from Jul 20, 2018

Conversation

knz
Copy link
Contributor

@knz knz commented Apr 28, 2018

Picks #25146.

@knz knz requested review from justinj, RaduBerinde and a team April 28, 2018 15:37
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@RaduBerinde
Copy link
Member

LGTM

@knz
Copy link
Contributor Author

knz commented Apr 28, 2018

Actually sequelize requires support for the syntax. #25148

@knz knz requested a review from a team April 28, 2018 16:27
@knz
Copy link
Contributor Author

knz commented Apr 28, 2018

@benesch @nvanbenschoten is it safe to cherry-pick this for our sequelize support, is it possible that sequelize will not hit this on the common case.

@knz
Copy link
Contributor Author

knz commented Jul 20, 2018

bors r+

@craig
Copy link
Contributor

craig bot commented Jul 20, 2018

Build failed

@knz
sql: report unimplemented error on ORDER BY in function arguments
e50de17 
CockroachDB currently does not support specifying the order of
aggregations (cockroachdb#23620) but accepts the syntax silently. This is not
useful, because it creates the wrong expectations with users and
prevents CRL from learning about user demand for the feature.

This patch ensures that the syntax reports an unimplemented error.

Note that this will break Sequelize support until the issue cockroachdb#25148 is
solved.

Release note (sql change): CockroachDB now properly reports an error
when a query attempts to use ORDER BY within a function argument list,
which is an unsupported feature.
@knz
Copy link
Contributor Author

knz commented Jul 20, 2018

ow I needed to rebase this

@knz
Copy link
Contributor Author

knz commented Jul 20, 2018

bors r+

craig bot pushed a commit that referenced this pull request Jul 20, 2018
@knz
Merge #25147
73a3556 
25147: cherrypick-2.0: sql: report unimplemented error on ORDER BY in function arguments r=knz a=knz

Picks #25146.


Co-authored-by: Raphael 'kena' Poss <knz@cockroachlabs.com>
@craig
Copy link
Contributor

craig bot commented Jul 20, 2018

Build succeeded

@craig craig bot merged commit e50de17 into cockroachdb:release-2.0 Jul 20, 2018
@knz knz deleted the backport2.0-25146 branch February 14, 2019 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinj justinj Awaiting requested review from justinj

@RaduBerinde RaduBerinde Awaiting requested review from RaduBerinde

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@knz @cockroach-teamcity @RaduBerinde