json: properly report capacity of encoded jsons #25679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
jordanlewis
force-pushed
the
enc-json-size
branch
from
b3c79fc
to
0f08aa7
Compare
Previously, jsonEncoded structs reported their memory size as including the underlying capacity of their encoded byte slices. This was incorrect, as usually that underlying slice is an entire kv batch. This problem led to significant overcounting of the memory used by queries that read JSON data from disk, which resulted in spurious BudgetExceededErrors. Release note (bug fix): prevent spurious BudgetExceededErrors for some queries that read a lot of JSON data from disk. Co-authored-by: Alfonso Subiotto Marqués <alfonso@cockroachlabs.com>
jordanlewis
force-pushed
the
enc-json-size
branch
from
0f08aa7
to
23280f4
Compare
|
@jordanlewis any relationship to #25607, which doesn't use json? |
|
@knz unfortunately not, those types seem to have correct |
asubiotto
approved these changes
May 19, 2018
|
Almost certainly a flake. Retriggered. |
|
TFTR! bors r+ |
craig bot
pushed a commit
that referenced
this pull request
May 19, 2018
25679: json: properly report capacity of encoded jsons r=jordanlewis a=jordanlewis Previously, jsonEncoded structs reported their memory size as including the underlying capacity of their encoded byte slices. This was incorrect, as usually that underlying slice is an entire kv batch. This problem led to significant overcounting of the memory used by queries that read JSON data from disk, which resulted in spurious BudgetExceededErrors. Release note (bug fix): prevent spurious BudgetExceededErrors for some queries that read a lot of JSON data from disk. Co-authored-by: Jordan Lewis <jordanthelewis@gmail.com>
Build succeeded |
craig bot
pushed a commit
that referenced
this pull request
May 19, 2018
25719: backport-2.0: json: properly report capacity of encoded jsons r=jordanlewis a=jordanlewis Backport 1/1 commits from #25679. /cc @cockroachdb/release Previously, jsonEncoded structs reported their memory size as including the underlying capacity of their encoded byte slices. This was incorrect, as usually that underlying slice is an entire kv batch. This problem led to significant overcounting of the memory used by queries that read JSON data from disk, which resulted in spurious BudgetExceededErrors. Release note (bug fix): prevent spurious BudgetExceededErrors for some queries that read a lot of JSON data from disk. Co-authored-by: Alfonso Subiotto Marqués <alfonso@cockroachlabs.com> Co-authored-by: Jordan Lewis <jordanthelewis@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, jsonEncoded structs reported their memory size as including
the underlying capacity of their encoded byte slices. This was
incorrect, as usually that underlying slice is an entire kv batch. This
problem led to significant overcounting of the memory used by queries
that read JSON data from disk, which resulted in spurious
BudgetExceededErrors.
Release note (bug fix): prevent spurious BudgetExceededErrors for some
queries that read a lot of JSON data from disk.