release-2.0: sql: miscellaneous INSERT, UPSERT and UPDATE correctness fixes #26181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The UPSERT code on the "happy" path (either the fast path, or the long path when there is no conflict) uses the INSERT row writer with a flag "ignore duplicate errors", with the expectation that code would do the Right Thing if the raw already exists (using KV Puts instead of CPuts). Unfortunately the INSERT rowwriter does the wrong thing when the row already existed before, and the new row (or a column family in the new row) contains just NULLs: in that case, the correct way to "update" the row in KV is to issue a Del, which INSERT (expectedly) didn't do. This patch addresses the issue by making the INSERT row writer able to issue Puts. Release note (bug fix): UPSERT is now properly able to write NULLs to every columns in tables containing more than one column family.
Prior to this patch, UPDATE on a column family other than the first where the column family only contains 1 column, would write an empty value in KV instead of erasing the K/V pair (as is expected). This appeared to be OK because the table reader currently automatically converts unexpected empty values in KV pairs to NULLs, but the error was messing up with KV tracing. Release note: None
This was a TODO left by @danhhz a long time ago. In fact merging this code was useful beyond DRY, since both implementations were performing slightly different optimizations that would benefit from being done together, always. Release note: None
|
This change is |
knz
added this to Triage
in (DEPRECATED) SQL Front-end, Lang & Semantics
via automation
knz
moved this from Triage
to Finished (milestone 0529)
in (DEPRECATED) SQL Front-end, Lang & Semantics
|
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks pending. Comments from Reviewable |
|
Thanks! bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 3/3 commits from #26169.
/cc @cockroachdb/release
Fixes #25726.