storage: Tick all replicas, not just unquiesced ones #26291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
Are you sure that it is the ticking of quiesced replicas that is the problem, and not something else in #24956 such as the changes to the campaigning logic? Review status: 0 of 1 files reviewed at latest revision, all discussions resolved, some commit checks pending. Comments from Reviewable |
This reverts the main effect of cockroachdb#24956. The supporting infrastructure is left in place to minimize merge conflicts and to aid in diagnosing why the maps get out of sync. Fixes cockroachdb#26257 Release note: None
bdarnell
force-pushed
the
revert-tickquiesced
branch
from
69e2f24
to
3106615
Compare
It looks that way. The new monitoring I added shows that for the ranges in the bad state, the leader's replica is marked as quiescent but it is not in the unquiescedReplicas map. |
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
May 31, 2018
26291: storage: Tick all replicas, not just unquiesced ones r=bdarnell a=bdarnell This reverts the main effect of #24956. The supporting infrastructure is left in place to minimize merge conflicts and to aid in diagnosing why the maps get out of sync. Fixes #26257 Release note: None Co-authored-by: Ben Darnell <ben@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the main effect of #24956. The supporting infrastructure
is left in place to minimize merge conflicts and to aid in diagnosing
why the maps get out of sync.
Fixes #26257
Release note: None