storage: Disable campaign-on-wake when receiving raft messages

[bdarnell]

When the incoming message is a MsgVote (which is likely the case for
the first message received by a quiesced follower), immediate
campaigning will cause the election to fail.

This is similar to reverting commit 44e3977, but only disables
campaigning in one location.

Fixes #26391

Release note: None

[cockroach-teamcity]

This change is 

[a-robinson]

but I didn't really vet every call point. Let me know if you'd like me to. Thanks for tracking this down!

---

Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

---

Comments from Reviewable

[petermattis]

---

Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

---

pkg/cmd/roachtest/cluster.go, line 721 at r1 (raw file):

	if local {
		// This avoids annoying firewall prompts on macos
		args = append(args, "--args", "--host=127.0.0.1")

Does that work? I would have though you needed --args=--host=127.0.0.1.

---

pkg/storage/replica.go, line 3456 at r2 (raw file):

	// include MsgVotes), so don't campaign if we wake up our raft
	// group.
	return r.withRaftGroup(false, func(raftGroup *raft.RawNode) (bool, error) {

An inline comment such as false /* mayCampaign */ would be helpful for future readers.

---

Comments from Reviewable

[bdarnell]

Review status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

---

pkg/cmd/roachtest/cluster.go, line 721 at r1 (raw file):

Previously, petermattis (Peter Mattis) wrote…

Does that work? I would have though you needed --args=--host=127.0.0.1.

Yes, it works.

---

pkg/storage/replica.go, line 3456 at r2 (raw file):

Previously, petermattis (Peter Mattis) wrote…

An inline comment such as false /* mayCampaign */ would be helpful for future readers.

Maybe, but then it's likely to push the function literal onto the next line so I don't think it's a net win.

---

Comments from Reviewable

[bdarnell]

bors r+

[craig]

Build succeeded

• GitHub CI (Cockroach)

[tbg]

LGTM 👍 going to try this on my 100k range cluster.