sql: add missing PostgreSQL built-in functions #26586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
2 tasks
knz
added this to Triage
in (DEPRECATED) SQL Front-end, Lang & Semantics
via automation
knz
moved this from Triage
to Current milestone
in (DEPRECATED) SQL Front-end, Lang & Semantics
|
Review status: pkg/sql/logictest/testdata/logic_test/builtin_function, line 42 at r1 (raw file):
This is also sensitive to SQL keywords, right? Do we need a test of that? Comments from Reviewable |
complete! 0 of 0 LGTMs obtained (and 1 stale)
|
Review status: pkg/sql/logictest/testdata/logic_test/builtin_function, line 42 at r1 (raw file): Previously, justinj (Justin Jaffray) wrote…
Nice catch. Done. Comments from Reviewable |
|
TFYR! bors r+ |
Build failed |
Release note (sql change): CockroachDB now supports the built-in functions `bit_length()`, `quote_ident()`, `quote_literal()`, `quote_nullable()`, and the aliases `char_length()` and `character_length()` for `length()`, for compatibility with PostgreSQL.
|
github API flake (502 server error) bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jun 11, 2018
26586: sql: add missing PostgreSQL built-in functions r=knz a=knz Fixes #26406. Release note (sql change): CockroachDB now supports the built-in functions `bit_length()`, `quote_ident()`, `quote_literal()`, `quote_nullable()`, and the aliases `char_length()` and `character_length()` for `length()`, for compatibility with PostgreSQL. Co-authored-by: Raphael 'kena' Poss <knz@cockroachlabs.com>
Build succeeded |
knz
moved this from Current milestone
to Finished (milestone 0529)
in (DEPRECATED) SQL Front-end, Lang & Semantics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26406.
Release note (sql change): CockroachDB now supports the built-in
functions
bit_length(),quote_ident(),quote_literal(),quote_nullable(), and the aliaseschar_length()andcharacter_length()forlength(), for compatibility withPostgreSQL.