sql: bugfix to interleaved join planning criteria #26756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
Can you add the simplified case you came up with as a logictest? |
|
Yeah, good point. Done. |
Previously, interleaved joins could take place if the tables were ancestors of each other, there was a merge join ordering on the equality columns, and the left equality columns were a prefix of the interleaved columns. These criteria are insufficient: the right equality columns must also be a prefix of the interleaved columns. A case where this wouldn't naturally hold is where the right equality columns get a merge join ordering because they're known to be constant. Release note (bug fix): joins across two interleaved tables no longer return incorrect results under certain circumstances when the equality columns aren't all part of the interleaved columns.
|
Review status: Comments from Reviewable |
complete! 0 of 0 LGTMs obtained (and 1 stale)
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jun 18, 2018
26756: sql: bugfix to interleaved join planning criteria r=jordanlewis a=jordanlewis Previously, interleaved joins could take place if the tables were ancestors of each other, there was a merge join ordering on the equality columns, and the left equality columns were a prefix of the interleaved columns. These criteria are insufficient: the right equality columns must also be a prefix of the interleaved columns. A case where this wouldn't naturally hold is where the right equality columns get a merge join ordering because they're known to be constant. Release note (bug fix): joins across two interleaved tables no longer return incorrect results under certain circumstances when the equality columns aren't all part of the interleaved columns. Fixes #25838. I verified that the new test fails before the fix was applied. Co-authored-by: Jordan Lewis <jordanthelewis@gmail.com>
Build succeeded |
craig bot
pushed a commit
that referenced
this pull request
Jun 19, 2018
26832: backport-2.0: sql: bugfix to interleaved join planning criteria r=jordanlewis a=jordanlewis Backport 1/1 commits from #26756. /cc @cockroachdb/release --- Previously, interleaved joins could take place if the tables were ancestors of each other, there was a merge join ordering on the equality columns, and the left equality columns were a prefix of the interleaved columns. These criteria are insufficient: the right equality columns must also be a prefix of the interleaved columns. A case where this wouldn't naturally hold is where the right equality columns get a merge join ordering because they're known to be constant. Release note (bug fix): joins across two interleaved tables no longer return incorrect results under certain circumstances when the equality columns aren't all part of the interleaved columns. Fixes #25838. I verified that the new test fails before the fix was applied. Co-authored-by: Jordan Lewis <jordanthelewis@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, interleaved joins could take place if the tables were
ancestors of each other, there was a merge join ordering on the equality
columns, and the left equality columns were a prefix of the interleaved
columns. These criteria are insufficient: the right equality columns
must also be a prefix of the interleaved columns. A case where this
wouldn't naturally hold is where the right equality columns get a merge
join ordering because they're known to be constant.
Release note (bug fix): joins across two interleaved tables no longer
return incorrect results under certain circumstances when the equality
columns aren't all part of the interleaved columns.
Fixes #25838. I verified that the new test fails before the fix was applied.