sql: unblacklist repeat builtin #28039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have memory accounting for it now. Also, change a test that was checking whether a top-k sort was correctly planned to a planner test that uses EXPLAIN, instead of using the repeat builtin in a roundabout fashion. Release note (sql change): permit distribution of queries that use the repeat builtin function.
|
This change is |
|
TFTR! bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jul 30, 2018
28039: sql: unblacklist repeat builtin r=jordanlewis a=jordanlewis We have memory accounting for it now. Also, change a test that was checking whether a top-k sort was correctly planned to a planner test that uses EXPLAIN, instead of using the repeat builtin in a roundabout fashion. Release note (sql change): permit distribution of queries that use the repeat builtin function. 28040: sql: mark DTime as having an ambiguous format r=jordanlewis a=jordanlewis Previously, DTime wasn't correctly marked as an AmbiguousFormat type. This caused misformatting of time types in DistSQL. Release note (bug fix): fix formatting of time datatypes in some circumstances. Co-authored-by: Jordan Lewis <jordanthelewis@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have memory accounting for it now. Also, change a test that was
checking whether a top-k sort was correctly planned to a planner test
that uses EXPLAIN, instead of using the repeat builtin in a roundabout
fashion.
Release note (sql change): permit distribution of queries that use the
repeat builtin function.