sql: remove/hide support for TIMETZ #28095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knz
added this to Triage
in (DEPRECATED) SQL Front-end, Lang & Semantics
via automation
|
This change is |
knz
force-pushed
the
20180731-hide-timetz
branch
from
33c977e
to
3893974
Compare
|
cc @rmloveland |
jordanlewis
approved these changes
Jul 31, 2018
|
@petermattis just suggested an alternate approach which I will try shortly. |
knz
moved this from Triage
to Candidate next milestone
in (DEPRECATED) SQL Front-end, Lang & Semantics
knz
moved this from Candidate next milestone
to Current milestone
in (DEPRECATED) SQL Front-end, Lang & Semantics
knz
force-pushed
the
20180731-hide-timetz
branch
from
3893974
to
c711d97
Compare
|
So the attempt was to keep the datum type but remove the table encoding (which was blatantly wrong) However the datum type was also wrong actually -- the package So I have opted for a full removal. We can always consider a revert later if we want to restore the functionality, e.g. on the |
knz
force-pushed
the
20180731-hide-timetz
branch
from
c711d97
to
e4b464b
Compare
This patch removes the support for TIMETZ that was previously introduced in the 2.1 branch. The protobuf ID for table schemas remains reserved, however any attempt to access a TIMETZ column in existing tables will cause a node to panic. Tables containing TIMETZ columns must be completely dropped, they cannot be recovered. Release note (backward-incompatible change): Support for PostgreSQL's TIMETZ data type is removed because it was incomplete/incorrect. This was a feature only available in previous 2.1-alpha releases but not any stable release, and thus was experimental anyways. Tables previously created with the TIMETZ data type must be dropped entirely -- it is not possible to convert the data or drop a single TIMETZ column.
knz
force-pushed
the
20180731-hide-timetz
branch
from
e4b464b
to
7c7e748
Compare
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Aug 13, 2018
28095: sql: remove/hide support for TIMETZ r=knz a=knz Fixes #25224. This patch removes the support for TIMETZ that was previously introduced in the 2.1 branch. The protobuf ID for table schemas remains reserved, however any attempt to access a TIMETZ column in existing tables will cause a node to panic. Tables containing TIMETZ columns must be completely dropped, they cannot be recovered. Release note (backward-incompatible change): Support for PostgreSQL's TIMETZ data type is removed because it was incomplete/incorrect. This was a feature only available in previous 2.1-alpha releases but not any stable release, and thus was experimental anyways. Tables previously created with the TIMETZ data type must be dropped entirely -- it is not possible to convert the data or drop a single TIMETZ column. cc @awoods187 Co-authored-by: Raphael 'kena' Poss <knz@cockroachlabs.com>
Build succeeded |
knz
moved this from Current milestone
to Finished (milestone 0731)
in (DEPRECATED) SQL Front-end, Lang & Semantics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25224.
This patch removes the support for TIMETZ that was previously
introduced in the 2.1 branch.
The protobuf ID for table schemas remains reserved, however any
attempt to access a TIMETZ column in existing tables will cause a node
to panic. Tables containing TIMETZ columns must be completely dropped,
they cannot be recovered.
Release note (backward-incompatible change): Support for PostgreSQL's
TIMETZ data type is removed because it was incomplete/incorrect. This
was a feature only available in previous 2.1-alpha releases but not
any stable release, and thus was experimental anyways. Tables
previously created with the TIMETZ data type must be dropped entirely
-- it is not possible to convert the data or drop a single TIMETZ
column.
cc @awoods187