cli: ensure user set --password can also modify the password #28197
Conversation
|
This change is |
|
@mberhault @bdarnell should we backport this to 2.0? |
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (and 1 stale)
pkg/sql/create_user.go
Outdated
| } | ||
|
|
||
| n.run.rowsAffected, err = params.extendedEvalCtx.ExecCfg.InternalExecutor.Exec( | ||
| params.ctx, | ||
| opName, | ||
| params.p.txn, | ||
| "insert into system.users values ($1, $2, $3)", | ||
| `upsert into system.users(username, "hashedPassword", "isRole") values ($1, $2, $3)`, |
There was a problem hiding this comment.
this isn't right, you can't use the CREATE USER command to modify a user, that's what the ALTER USER command is for.
Until now the flag `--password` could only set the password if the user did not exist previously (ie. during user creation). This patch fixes the feature so that `--password` can be used to change an existing user's password. Release note (bug fix): `cockroach user set --password` can now change the password of existing users.
There was a problem hiding this comment.
Reviewable status:
pkg/sql/create_user.go, line 125 at r1 (raw file):
Previously, mberhault (marc) wrote…
this isn't right, you can't use the
CREATE USERcommand to modify a user, that's what theALTER USERcommand is for.
Oh I see.
Thanks for catching this. Fixed. PTAL.
|
LGTM. Thanks for that. |
|
👎 Rejected by code reviews |
|
bors r+ |
28197: cli: ensure user set --password can also modify the password r=knz a=knz Fixes #27882. Until now the flag `--password` could only set the password if the user did not exist previously (ie. during user creation). This patch fixes the feature so that `--password` can be used to change an existing user's password. Release note (bug fix): `cockroach user set --password` can now change the password of existing users. Co-authored-by: Raphael 'kena' Poss <knz@cockroachlabs.com>
Build succeeded |
Fixes #27882.
Until now the flag
--passwordcould only set the password if theuser did not exist previously (ie. during user creation). This patch
fixes the feature so that
--passwordcan be used to change anexisting user's password.
Release note (bug fix):
cockroach user set --passwordcan now changethe password of existing users.