cli: Add rangelog info to debug zip #28396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the rangelog admin server endpoint, which currently grabs the entire rangelog without an ORDER BY or LIMIT clause due to the performance reasons outlined in cockroachdb#18159. Release note (cli change): The file generated by running debug zip now contains the contents of the system.rangelog table, which is a record of range splits and rebalances in the cluster.
|
This change is |
a-robinson
commented
Aug 9, 2018
There was a problem hiding this comment.
The underlying problems haven't been fixed as far as I know. #18159 was closed when we defaulted the admin server endpoint to not use an ORDER BY or LIMIT in (#18376), not because we made the query with ORDER BY and/or LIMIT clauses faster.
The core problems IIRC were reverse scans being much slower than forward scans (#14228), the lack of a column family on the rangelog table (#17901), and the LIMIT clause disabling DistSQL.
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Aug 9, 2018
28396: cli: Add rangelog info to debug zip r=a-robinson a=a-robinson Using the rangelog admin server endpoint, which currently grabs the entire rangelog without an ORDER BY or LIMIT clause due to the performance reasons outlined in #18159. Release note (cli change): The file generated by running debug zip now contains the contents of the system.rangelog table, which is a record of range splits and rebalances in the cluster. Co-authored-by: Alex Robinson <alexdwanerobinson@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the rangelog admin server endpoint, which currently grabs the
entire rangelog without an ORDER BY or LIMIT clause due to the
performance reasons outlined in #18159.
Release note (cli change): The file generated by running debug zip
now contains the contents of the system.rangelog table, which is a
record of range splits and rebalances in the cluster.