importccl: normalize case of imported mysql table names #28397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
knz
reviewed
Aug 9, 2018
There was a problem hiding this comment.
I seem to recognize the change we've discussed, but what of the CI failures?
Reviewed 6 of 6 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained
|
I think I took one last look at the testdata in my editor and then saved the file which mangled some of the non-unicode bytes? I donno, regenerating it seems to fix it. |
MySQL quotes table named in its input but is still case-insensitive. Normalizing the names when importing (to lowercase) should also meant that any unquoted name in cockroach will match (since they'll be normalized before resolution). Fixes cockroachdb#28036. Release note (sql change): normalize case of mysqldump imported table names.
maddyblue
approved these changes
Aug 9, 2018
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Aug 9, 2018
28397: importccl: normalize case of imported mysql table names r=dt a=dt MySQL quotes table named in its input but is still case-insensitive. Normalizing the names when importing (to lowercase) should also meant that any unquoted name in cockroach will match (since they'll be normalized before resolution). Fixes #28036. Release note (sql change): normalize case of mysqldump imported table names. Co-authored-by: David Taylor <tinystatemachine@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MySQL quotes table named in its input but is still case-insensitive. Normalizing the names
when importing (to lowercase) should also meant that any unquoted name in cockroach will
match (since they'll be normalized before resolution).
Fixes #28036.
Release note (sql change): normalize case of mysqldump imported table names.