roachtest: fix version/* tests #28472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a `quit` command line that is compatible with 2.0. This was accidentally broken in cockroachdb#28373. Fixes cockroachdb#28453 Fixes cockroachdb#28454 Release note: None
|
This change is |
danhhz
approved these changes
Aug 10, 2018
|
bors r=danhhz |
Build succeeded |
petermattis
added a commit
to petermattis/cockroach
that referenced
this pull request
Aug 11, 2018
This is the same fix as cockroachdb#28472, but for a different test. Use a `quit` command line that is compatible with 2.0. This was accidentally broken in cockroachdb#28373. Fixes cockroachdb#28452 Release note: None
craig bot
pushed a commit
that referenced
this pull request
Aug 11, 2018
28489: roachtest: fix upgrade test r=tschottdorf a=petermattis This is the same fix as #28472, but for a different test. Use a `quit` command line that is compatible with 2.0. This was accidentally broken in #28373. Fixes #28452 Release note: None Co-authored-by: Peter Mattis <petermattis@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a
quitcommand line that is compatible with 2.0. This wasaccidentally broken in #28373.
Fixes #28453
Fixes #28454
Release note: None