cli: format byte results like in SQL #28494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch changes the formatting of byte array results to become the same as converting a byte array to a string using a cast, with `bytea_output` set to `escape`. This is both a simplification of the code and a reduction of UX surprise. Release note (cli change): `cockroach` commands that print SQL results containing byte array now print them as if they were converted by a SQL cast to the `string` type.
|
This change is |
BramGruneir
approved these changes
Aug 13, 2018
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained
BramGruneir
approved these changes
Aug 13, 2018
There was a problem hiding this comment.
Reviewable status:
|
TFYR!
bors r+
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
|
craig bot
pushed a commit
that referenced
this pull request
Aug 14, 2018
28494: cli: format byte results like in SQL r=knz a=knz Fixes #20525. This patch changes the formatting of byte array results to become the same as converting a byte array to a string using a cast, with `bytea_output` set to `escape`. This is both a simplification of the code and a reduction of UX surprise. Release note (cli change): `cockroach` commands that print SQL results containing byte array now print them as if they were converted by a SQL cast to the `string` type. Co-authored-by: Raphael 'kena' Poss <knz@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20525.
This patch changes the formatting of byte array results to become
the same as converting a byte array to a string using a cast,
with
bytea_outputset toescape.This is both a simplification of the code and a reduction of UX
surprise.
Release note (cli change):
cockroachcommands that print SQLresults containing byte array now print them as if they
were converted by a SQL cast to the
stringtype.