sql: fix index-id does not exist when ADD/DROP COLUMN #28803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this was being caused by pitfall: https://play.golang.org/p/H8Rzb3_rywr fixes cockroachdb#27402 Release note (sql change): Fix ADD/DROP COLUMN index-id does not exist error
|
This change is |
benesch
approved these changes
Aug 19, 2018
There was a problem hiding this comment.
Nice find! That can't have been fun to track down.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (and 1 stale)
pkg/sql/backfill/backfill.go, line 149 at r1 (raw file):
) for i, fkTableDesc := range otherTables { found, ok := fkTables[fkTableDesc.ID]
One other pattern I've seen to prevent accidents is:
for i := range otherTables {
fkTableDesc := &otherTables[i]
}
That way you don't ever have to think about whether you're using the "correct" reference to fkTableDesc in the body of the loop.
knz
approved these changes
Aug 19, 2018
There was a problem hiding this comment.
Reviewable status:
|
TFTR! |
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Aug 20, 2018
28803: sql: fix index-id does not exist when ADD/DROP COLUMN r=vivekmenezes a=vivekmenezes this was being caused by pitfall: https://play.golang.org/p/H8Rzb3_rywr fixes #27402 Release note (sql change): Fix ADD/DROP COLUMN index-id does not exist error Co-authored-by: Vivek Menezes <vivek@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this was being caused by pitfall:
https://play.golang.org/p/H8Rzb3_rywr
fixes #27402
Release note (sql change): Fix ADD/DROP COLUMN
index-id does not exist error