opt,sql: do not allow special functions in ON clause #28839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, both the heuristic planner and the optimizer were erroneously allowing ON clauses to have special functions such as generator functions or aggregates. This commit ensures that any queries containing special functions in the ON clause now throw an error. Fixes cockroachdb#28817 Release note (sql change): Previously, CockroachDB was erroneously allowing generator functions, aggregates, and window functions in the ON clause of joins. These functions are no longer allowed in join conditions, and will cause an error if used.
|
This change is |
|
Nice find! |
RaduBerinde
approved these changes
Aug 20, 2018
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (and 1 stale)
craig bot
pushed a commit
that referenced
this pull request
Aug 20, 2018
28839: opt,sql: do not allow special functions in ON clause r=rytaft a=rytaft Previously, both the heuristic planner and the optimizer were erroneously allowing ON clauses to have special functions such as generator functions or aggregates. This commit ensures that any queries containing special functions in the ON clause now throw an error. Fixes #28817 Release note (sql change): Previously, CockroachDB was erroneously allowing generator functions, aggregates, and window functions in the ON clause of joins. These functions are no longer allowed in join conditions, and will cause an error if used. 28850: sql: improve memory accounting for replace builtin r=solongordon a=solongordon Previously the replace(...) builtin was only reserving memory after the replace operation was performed, so it was possible to outspend the memory budget. Now we do a worst case reservation beforehand and adjust it based on the actual result size. Fixes #28206 Release note: None Co-authored-by: Rebecca Taft <becca@cockroachlabs.com> Co-authored-by: Solon Gordon <solon@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, both the heuristic planner and the optimizer were
erroneously allowing ON clauses to have special functions such
as generator functions or aggregates. This commit ensures that
any queries containing special functions in the ON clause now
throw an error.
Fixes #28817
Release note (sql change): Previously, CockroachDB was
erroneously allowing generator functions, aggregates, and window
functions in the ON clause of joins. These functions are no longer
allowed in join conditions, and will cause an error if used.