release-2.1: changefeedccl,roachtest: more changefeed introspection for debugging #28923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix up the roachtests to use the high-water timestamp in crdb_internal.jobs, now that it exists. Also length the roachtest to get a better sense of how variable the latencies are over a longer period. Add a couple more metrics (changefeed.emit_nanos and changefeed.flushes) that are helpful in debugging performance problems with the sink. Timeseries storage is expensive, is this too many metrics? Release note (enterprise change): Added additional monitoring metrics for changefeeds.
|
This change is |
|
@mrtracy any thoughts on this? |
mrtracy
reviewed
Aug 27, 2018
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (and 1 stale)
|
TFTR! bors r=mrtracy |
craig bot
pushed a commit
that referenced
this pull request
Aug 27, 2018
28923: release-2.1: changefeedccl,roachtest: more changefeed introspection for debugging r=mrtracy a=danhhz Backport 1/1 commits from #28853. /cc @cockroachdb/release Closes #28922. --- Fix up the roachtests to use the high-water timestamp in crdb_internal.jobs, now that it exists. Also length the roachtest to get a better sense of how variable the latencies are over a longer period. Add a couple more metrics (changefeed.emit_nanos and changefeed.flushes) that are helpful in debugging performance problems with the sink. Timeseries storage is expensive, is this too many metrics? Release note (enterprise change): Added additional monitoring metrics for changefeeds. Co-authored-by: Daniel Harrison <daniel.harrison@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #28853.
/cc @cockroachdb/release
Closes #28922.
Fix up the roachtests to use the high-water timestamp in
crdb_internal.jobs, now that it exists. Also length the roachtest to get
a better sense of how variable the latencies are over a longer period.
Add a couple more metrics (changefeed.emit_nanos and changefeed.flushes)
that are helpful in debugging performance problems with the sink.
Timeseries storage is expensive, is this too many metrics?
Release note (enterprise change): Added additional monitoring metrics
for changefeeds.