backport-2.1: cli: Fix support for deprecated --http-host flag #29220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like we accidentally stopped registering the --http-host flag in the cli package's init function recently, which completely removed support for --http-host rather than the intended effect of deprecating (but continuing to allow) it. Also make the handling of deprecated/alias flags more consistent with each other while I'm here. Release note (bug fix): Fix support for --http-host flag that was broken in previous 2.1 beta releases.
|
This change is |
knz
approved these changes
Aug 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #29213.
/cc @cockroachdb/release
It looks like we accidentally stopped registering the --http-host flag
in the cli package's init function recently, which completely removed
support for --http-host rather than the intended effect of deprecating
(but continuing to allow) it.
Also make the handling of deprecated/alias flags more consistent with
each other while I'm here.
Release note (bug fix): Fix support for --http-host flag that was broken
in previous 2.1 beta releases.