release-2.1: ui: design updates to the Statements pages #30115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows very short tooltips to take up less space. Release note (admin ui change): Make short tooltips take up less space.
Previously, the hover area for tooltips would only expand to the content of the tooltip, which is problematic in some cases. Release note (admin ui change): Make some tooltips easier to access.
Release note: none
Release note (admin ui change): Simplify the appearance of the Statements pages.
To highlight the critical metric of statement retries, we split them out into a distinct column on the Statements page. Also, adjust the table layout a bit to make space for the new column. Release note (admin ui change): Add statement retries to Statements table.
Release note (admin ui change): Right align all numeric stats on Statements page.
Release note (admin ui change): Improve the tooltips on the Statements list and details pages by adding a legend detailing the parts of the bar chart.
Release note: None
Add a bar to the total execution count, and root the max retries bar at zero. Release note: None
Release note: None
To make clear which rows summarize the other rows. Release note (admin ui change): Highlight summary rows in Statement Details tables.
Release note (admin ui change): Improve the headers for the Statement Details tables.
Release note (admin ui change): Adds a few explanatory tooltips to Statement Details tables.
Release note (admin ui change): Reorder the Statement Details tables to highlight the most useful data.
Release note (admin ui change): Widen Statement Details bar charts.
Release note: None
Release note (admin ui change): Summarize SET statements in Statements table.
Release note (admin ui change): Clean up the layout of the Statements page.
Release note: None
Release note: None
The arrow on the sortable table column headers was previously quite small. This increases the size to match the heaeder text size. Release note: None
Release note: None
Release note: None
Release note (admin ui change): Add a clarifying tooltip to the Statement Details page By Gateway Node table.
Contributes to: cockroachdb#29676 Release note (admin ui change): When a statement fingerprint has sometimes failed, used the optimizer, or been distributed (but not always), show the number of executions that match.
Release note: None
Release note: None
Our built-in app names sometimes contain spaces, which then look awfully weird with line breaks inside. Release note: None
I will readily admit that this is a moderately hacky solution. I have already filed cockroachdb#29640 to come back and clean this up. Release note: None
|
This change is |
vilterp
approved these changes
Sep 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 29/29 commits from #29204.
/cc @cockroachdb/release
Included are a variety of updates to the Statements list and details pages, working to make these pages as immediately useful as possible.
List page, before:
List page, after:
Details page, before:
Details page, after:
