storage: Transfer lease to least-loaded store when rebalancing replicas #30256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
LGTM.
Any way to add a test to make sure the logic is correct?
…On Sat, Sep 15, 2018, 15:44 cockroach-teamcity ***@***.***> wrote:
This change is [image: Reviewable]
<https://reviewable.io/reviews/cockroachdb/cockroach/30256>
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#30256 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABihuVf60jYH7RxX4mFv_ScigUoINyBdks5ubViAgaJpZM4WqgvQ>
.
|
a-robinson
commented
Sep 17, 2018
a-robinson
force-pushed
the
leasetarget
branch
from
38d1c58
to
aa4319d
Compare
|
ping @BramGruneir |
BramGruneir
approved these changes
Sep 19, 2018
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, 3 of 3 files at r2.
Reviewable status:complete! 0 of 0 LGTMs obtained (and 1 stale)
|
bors r+ |
Build failed (retrying...) |
Build failed (retrying...) |
Build failed |
a-robinson
force-pushed
the
leasetarget
branch
from
aa4319d
to
8c325ee
Compare
|
Updated one line in the test to fix merge skew with #30143. bors r+ |
Build failed |
|
Heh, now that I've rebased on master it's failing due to #30435. I'll fix that up before continuing with this. |
|
I'll wait on this until #30422 is in, since it fixes the test failures. |
This logic was totally busted before due to indexing into the wrong replicas slice, meaning we would often transfer the lease to the wrong store. Also add a proper test for the replica/lease selection logic. Release note: None
Further protect against picking rebalance targets that are somewhat full by both extending the allocator_scorer convergeScore logic to add an extra score for overfull stores, and add a couple fallback checks to back up the convergeScore logic when needed. Release note: None
a-robinson
force-pushed
the
leasetarget
branch
from
8c325ee
to
dda75b7
Compare
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Sep 20, 2018
27921: kubernetes: Add a secure config that can use externally created certs r=a-robinson a=a-robinson For Kubernetes clusters that don't sign certificates properly, such as EKS as discovered in a recent forum post: https://forum.cockroachlabs.com/t/secure-cockroachdb-cluster-on-aws-eks/1824 Release note: None -------------------- It's arguable that this isn't worth checking in. I'm not too attached to it if folks don't think we should, I just needed to publish it somewhere for the original poster of https://forum.cockroachlabs.com/t/secure-cockroachdb-cluster-on-aws-eks/1824 to be able to use it. Touches #24527 30256: storage: Transfer lease to least-loaded store when rebalancing replicas r=a-robinson a=a-robinson This logic was totally busted before due to indexing into the wrong replicas slice, meaning we would often transfer the lease to the wrong store. Release note: None Co-authored-by: Alex Robinson <alexdwanerobinson@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This logic was totally busted before due to indexing into the wrong
replicas slice, meaning we would often transfer the lease to the wrong
store.
Release note: None