release-2.1: server: include saved profiles in debug zip #30281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds gRPC endpoints to access the heapfiles that were generated and stored when a possible OOM situation is detected. More specifically, when Cockroach RSS is more than 85%. A previous PR (cockroachdb#26797) saw to generate and store these profiles. This commit aims to allow these profiles to be accessed by the debug zip tool. Resolves: cockroachdb#26222 Release note (cli change): debug zip now also collects heap profiles that were generated and stored when there was high memory usage
|
This change is |
|
LGTM |
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Sep 17, 2018
30281: release-2.1: server: include saved profiles in debug zip r=ridwanmsharif a=ridwanmsharif Backport 1/1 commits from #29994. /cc @cockroachdb/release --- This change adds gRPC endpoints to access the heapfiles that were generated and stored when a possible OOM situation is detected. More specifically, when Cockroach RSS is more than 85%. A previous PR (#26797) saw to generate and store these profiles. This commit aims to include these profiles in the debug zip tool. Resolves: #26222 Release note (cli change): debug zip now also collects heap profiles that were generated and stored when there was high memory usage Co-authored-by: Ridwan Sharif <ridwanmsharif@ridwans-macbook-pro.local>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #29994.
/cc @cockroachdb/release
This change adds gRPC endpoints to access the heapfiles that were
generated and stored when a possible OOM situation is detected. More
specifically, when Cockroach RSS is more than 85%. A previous PR
(#26797) saw to generate and store these profiles. This commit aims to
include these profiles in the debug zip tool.
Resolves: #26222
Release note (cli change): debug zip now also collects heap profiles
that were generated and stored when there was high memory usage