distsqlrun: fix lookup join with limit #30819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
RaduBerinde
approved these changes
Oct 1, 2018
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (and 1 stale)
pkg/sql/distsqlrun/joinreader.go, line 536 at r1 (raw file):
// emitRow returns the next row from jr.toEmit, if present. Otherwise it // prepares for another input batch. func (jr *joinReader) emitRow() (joinReaderState, sqlbase.EncDatumRow, *ProducerMetadata) {
[nit] remove the last return which is always nil
solongordon
reviewed
Oct 1, 2018
There was a problem hiding this comment.
Next() just to be more consistent with other processors like hashjoiner.
Reviewable status:
Previously, lookup join used its processRowHelper in an inappropriate place (not directly before returning a row) which caused the final rows in a limit query to get omitted in certain cases. Correct this problem. Release note (bug fix): lookup joins no longer omit rows in certain circumstances during limit queries.
jordanlewis
force-pushed
the
fix-lj-limit
branch
from
54cd53c
to
7ba018c
Compare
jordanlewis
commented
Oct 1, 2018
There was a problem hiding this comment.
Good idea, done.
Reviewable status:
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Oct 1, 2018
30819: distsqlrun: fix lookup join with limit r=jordanlewis a=jordanlewis Previously, lookup join used its processRowHelper in an inappropriate place (not directly before returning a row) which caused the final rows in a limit query to get omitted in certain cases. Correct this problem. Fixes #30812. Release note (bug fix): lookup joins no longer omit rows in certain circumstances during limit queries. Co-authored-by: Jordan Lewis <jordanthelewis@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, lookup join used its processRowHelper in an inappropriate
place (not directly before returning a row) which caused the final rows
in a limit query to get omitted in certain cases. Correct this problem.
Fixes #30812.
Release note (bug fix): lookup joins no longer omit rows in certain
circumstances during limit queries.