release-2.1: sql: remove protobuf output from show zone configurations
#31089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This shouldn't be in the output for the 2.1 release, the tests that use this to verify zone configs now can use the `crdb_internal.zones` table. Release note (sql change): output of `SHOW ZONE CONFIGURATIONS` and `SHOW ZONE CONFIGURATION FOR` now only shows the zone name and the SQL representation of the config.
|
This change is |
benesch
approved these changes
Oct 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #30985.
/cc @cockroachdb/release
This shouldn't be in the output for the 2.1 release,
the tests that use this to verify zone configs now
can use the
crdb_internal.zonestable.Also as suggested by @knz we could change the name
of the column from
cli_specifiertozone_namebut stillhave an alias to the old name for backwards compat with the cli.
I haven't seen that done anywhere though, how can I do
that exactly?
Release note: output of
SHOW ZONE CONFIGURATIONSand
SHOW ZONE CONFIGURATION FORnow only shows the zone nameand the SQL representation of the config.