opt: build IS OF (...) expression #31393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
rytaft
approved these changes
Oct 15, 2018
There was a problem hiding this comment.
Maybe you should open an issue for the bug?
Reviewed 5 of 5 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (and 1 stale)
knz
approved these changes
Oct 15, 2018
pkg/sql/sem/tree/eval_test.go
Outdated
| {`ARRAY['hello']::STRING[] IS OF (INT[])`, `false`}, | ||
| {`3::INT2 IS OF (INT2)`, `true`}, | ||
|
|
||
| // TODO(justin): these are currently incorrect. |
There was a problem hiding this comment.
you can link the issue number in the comment
This commit builds expressions of the form x IS OF (...). This is an optbuilder-only change since the value of such an expression is always known at plan time. This is also performed statically in Postgres, in the file src/backend/parser/parse_expr.c in the function transformAExprOf. This commit also partially fixes a bug in the heuristic planner's implementation of this feature by using `Equivalent` instead of `FamilyEqual` to compare types, resulting in `INT[]` being considered distinct from `STRING[]`. It also exposes a bug that I think is difficult to fix at the moment, which is that the lack of a 1-1 mapping between datum and column types means the following is incorrectly reported as true: ``` 3::INT2 IS OF (INT4) ``` I've added relevant test cases and added a TODO for that case. Tagging @knz for the heuristic planner change and also to put the type-related bug on his radar. Release note (bug fix): Fixed IS OF (...) expressions to no longer report arrays with different element types as being the same.
|
TFTRs! bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Oct 16, 2018
31393: opt: build IS OF (...) expression r=justinj a=justinj This commit builds expressions of the form x IS OF (...). This is an optbuilder-only change since the value of such an expression is always known at plan time. This commit also partially fixes a bug in the heuristic planner's implementation of this feature by using `Equivalent` instead of `FamilyEqual` to compare types, resulting in `INT[]` being considered distinct from `STRING[]`. It also exposes a bug that I think is difficult to fix at the moment, which is that the lack of a 1-1 mapping between datum and column types means the following is incorrectly reported as true: ``` 3::INT2 IS OF (INT4) ``` I've added relevant test cases and added a TODO for that case. Tagging @knz for the heuristic planner change and also to put the remaining type-related bug on his radar. Release note (bug fix): Fixed IS OF (...) expressions to no longer report arrays with different element types as being the same. Co-authored-by: Justin Jaffray <justin@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit builds expressions of the form x IS OF (...). This is an
optbuilder-only change since the value of such an expression is always
known at plan time.
This commit also partially fixes a bug in the heuristic planner's
implementation of this feature by using
Equivalentinstead ofFamilyEqualto compare types, resulting inINT[]being considereddistinct from
STRING[]. It also exposes a bug that I think isdifficult to fix at the moment, which is that the lack of a 1-1 mapping
between datum and column types means the following is incorrectly
reported as true:
I've added relevant test cases and added a TODO for that case.
Tagging @knz for the heuristic planner change and also to put the
remaining type-related bug on his radar.
Release note (bug fix): Fixed IS OF (...) expressions to no longer
report arrays with different element types as being the same.