kv: avoid transaction too large error if already refreshed #31733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
This change is |
|
TFTR! bors r+ |
|
👎 Rejected by PR status |
This fixes a bug where a txn that already refreshed its spans and no longer needed them could still run into a "transaction is too large to complete" error. This will be backported to 2.0 and 2.1. Release note (bug fix): Fix bug where transactions unnecessarily hit "too large" error.
nvanbenschoten
force-pushed
the
nvanbenschoten/refreshUpdate
branch
from
34c9226
to
c03b554
Compare
|
bors r+ |
Build failed |
|
Running into the bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Oct 24, 2018
31733: kv: avoid transaction too large error if already refreshed r=nvanbenschoten a=nvanbenschoten This fixes a bug where a txn that already refreshed its spans and no longer needed them could still run into a "transaction is too large to complete" error. This will be backported to 2.0 and 2.1. Release note (bug fix): Fix bug where transactions unnecessarily hit "too large" error. Co-authored-by: Nathan VanBenschoten <nvanbenschoten@gmail.com>
Build succeeded |
This was referenced Oct 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where a txn that already refreshed its spans
and no longer needed them could still run into a "transaction
is too large to complete" error.
This will be backported to 2.0 and 2.1.
Release note (bug fix): Fix bug where transactions unnecessarily
hit "too large" error.