release-2.1: sql: fix pg_catalog.pg_constraint's confkey column #31895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this patch, all columns in the index were included instead of only the ones being used in the foreign key reference. Fixes cockroachdb#31545. Release note (bug fix): Fix pg_catalog.pg_constraint's confkey column from including columns that were not involved in the foreign key reference.
BramGruneir
added this to Triage
in (DEPRECATED) SQL Front-end, Lang & Semantics
via automation
|
This change is |
|
DNM until after 2.1 release. |
knz
reviewed
Oct 25, 2018
pkg/sql/pg_catalog.go
Outdated
| if conkey, err = colIDArrayToDatum(con.Index.ColumnIDs); err != nil { | ||
| columnIDs := con.Index.ColumnIDs | ||
| if int(con.FK.SharedPrefixLen) > len(columnIDs) { | ||
| return errors.Errorf( |
There was a problem hiding this comment.
In both master and this backport, please replace this by return pgerror.NewAssertionErrorf(...) and simplify the sentence.
There was a problem hiding this comment.
Sure, incoming PR for master.
And I'll add the new commit to this PR.
Reword and convert a generic error to a pgerror. Release note: None
knz
moved this from Triage
to Finished (m2.2-1)
in (DEPRECATED) SQL Front-end, Lang & Semantics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #31610.
/cc @cockroachdb/release
Prior to this patch, all columns in the index were included instead of only the
ones being used in the foreign key reference.
Fixes #31545.
Release note (bug fix): Fix pg_catalog.pg_constraint's confkey column from
including columns that were not involved in the foreign key reference.