backport-2.1: opt,sql: fix correctness with JSON normalization #32214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
Adding @andy-kimball as a reviewer since Radu is on vacation |
andy-kimball
approved these changes
Nov 15, 2018
complete! 1 of 0 LGTMs obtained
justinj
force-pushed
the
backport2.1-31751
branch
2 times, most recently
from
44f3633
to
48e6517
Compare
|
Looks like this has been ready to go for a long time, do you plan to merge it? |
justinj
force-pushed
the
backport2.1-31751
branch
from
48e6517
to
77f93d9
Compare
Prior to this commit, we would normalize expressions of the form
`a->'b' = c` to `a @> {"b": c}` unconditionally. This was valid in many
important cases because containment is equivalent to equality for scalar
values. However, it is *not* valid if `c` is a non-scalar, as this
example illustrates:
`'{"a": [1, 2, 3]}'->'a' = [1]` => `false`
=>
`'{"a": [1, 2, 3]}' @> {"a": [1]}` => `true`
Since this bug was present in 2.0 I think it's not urgent to get it into
2.1.0, but I will target backporting it to 2.1.1.
Release note (bug fix): Fixed a bug that would incorrectly cause JSON
field access equality comparisons to be true when they should be false.
justinj
force-pushed
the
backport2.1-31751
branch
from
77f93d9
to
e4fd681
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, we would normalize expressions of the form
a->'b' = ctoa @> {"b": c}unconditionally. This was valid in manyimportant cases because containment is equivalent to equality for scalar
values. However, it is not valid if
cis a non-scalar, as thisexample illustrates:
'{"a": [1, 2, 3]}'->'a' = [1]=>false=>
'{"a": [1, 2, 3]}' @> {"a": [1]}=>trueSince this bug was present in 2.0 I think it's not urgent to get it into
2.1.0, but I will target backporting it to 2.1.1.
Release note (bug fix): Fixed a bug that would incorrectly cause JSON
field access equality comparisons to be true when they should be false.