backport-2.1: opt,sql: fix correctness with JSON normalization #32214
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, we would normalize expressions of the form
a->'b' = c
toa @> {"b": c}
unconditionally. This was valid in manyimportant cases because containment is equivalent to equality for scalar
values. However, it is not valid if
c
is a non-scalar, as thisexample illustrates:
'{"a": [1, 2, 3]}'->'a' = [1]
=>false
=>
'{"a": [1, 2, 3]}' @> {"a": [1]}
=>true
Since this bug was present in 2.0 I think it's not urgent to get it into
2.1.0, but I will target backporting it to 2.1.1.
Release note (bug fix): Fixed a bug that would incorrectly cause JSON
field access equality comparisons to be true when they should be false.