New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storageccl: support per-statement credentials param for GCS #32544

Merged
merged 1 commit into from Dec 3, 2018

Conversation

Projects
None yet
3 participants
@lucy-zhang
Copy link
Contributor

lucy-zhang commented Nov 21, 2018

Previously, the options for GCS authentication for bulk IO were:

  • set the value of cloudstorage.gs.default.key (auth=default)
  • use the GCP SDK's implicit auth (auth=implicit)

This change adds the option auth=specified, allowing the JSON key object to
be sent in the new credentials query param, allowing for authentication on a
per-statement basis.

Fixes #31602

Release note (enterprise change): Adds the option to supply Google Cloud
Storage credentials on a per-statement basis with the query parameter
credentials.

storageccl: support per-statement credentials param for GCS
Previously, the options for GCS authentication for bulk IO were:

* set the value of `cloudstorage.gs.default.key` (`auth=default`)
* use the GCP SDK's implicit auth (`auth=implicit`)

This change adds the option `auth=specified`, allowing the JSON key object to
be sent in the new `credentials` query param, allowing for authentication on a
per-statement basis.

Fixes #31602

Release note (enterprise change): Adds the option to supply Google Cloud
Storage credentials on a per-statement basis with the query parameter
`credentials`.

@lucy-zhang lucy-zhang requested a review from dt Nov 21, 2018

@lucy-zhang lucy-zhang requested review from cockroachdb/core-prs as code owners Nov 21, 2018

@cockroach-teamcity

This comment has been minimized.

Copy link
Member

cockroach-teamcity commented Nov 21, 2018

This change is Reviewable

@dt
Copy link
Member

dt left a comment

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@lucy-zhang

This comment has been minimized.

Copy link
Contributor

lucy-zhang commented Dec 3, 2018

bors r+

craig bot pushed a commit that referenced this pull request Dec 3, 2018

Merge #32544
32544: storageccl: support per-statement credentials param for GCS r=lucy-zhang a=lucy-zhang

Previously, the options for GCS authentication for bulk IO were:

* set the value of `cloudstorage.gs.default.key` (`auth=default`)
* use the GCP SDK's implicit auth (`auth=implicit`)

This change adds the option `auth=specified`, allowing the JSON key object to
be sent in the new `credentials` query param, allowing for authentication on a
per-statement basis.

Fixes #31602

Release note (enterprise change): Adds the option to supply Google Cloud
Storage credentials on a per-statement basis with the query parameter
`credentials`.

Co-authored-by: Lucy Zhang <lucy-zhang@users.noreply.github.com>
@craig

This comment has been minimized.

Copy link

craig bot commented Dec 3, 2018

Build succeeded

@craig craig bot merged commit 844cb6b into cockroachdb:master Dec 3, 2018

3 checks passed

GitHub CI (Cockroach) TeamCity build finished
Details
bors Build succeeded
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment