storageccl: support per-statement credentials param for GCS #32544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the options for GCS authentication for bulk IO were: * set the value of `cloudstorage.gs.default.key` (`auth=default`) * use the GCP SDK's implicit auth (`auth=implicit`) This change adds the option `auth=specified`, allowing the JSON key object to be sent in the new `credentials` query param, allowing for authentication on a per-statement basis. Fixes cockroachdb#31602 Release note (enterprise change): Adds the option to supply Google Cloud Storage credentials on a per-statement basis with the query parameter `credentials`.
|
This change is |
dt
reviewed
Dec 3, 2018
complete! 1 of 0 LGTMs obtained
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Dec 3, 2018
32544: storageccl: support per-statement credentials param for GCS r=lucy-zhang a=lucy-zhang Previously, the options for GCS authentication for bulk IO were: * set the value of `cloudstorage.gs.default.key` (`auth=default`) * use the GCP SDK's implicit auth (`auth=implicit`) This change adds the option `auth=specified`, allowing the JSON key object to be sent in the new `credentials` query param, allowing for authentication on a per-statement basis. Fixes #31602 Release note (enterprise change): Adds the option to supply Google Cloud Storage credentials on a per-statement basis with the query parameter `credentials`. Co-authored-by: Lucy Zhang <lucy-zhang@users.noreply.github.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the options for GCS authentication for bulk IO were:
cloudstorage.gs.default.key(auth=default)auth=implicit)This change adds the option
auth=specified, allowing the JSON key object tobe sent in the new
credentialsquery param, allowing for authentication on aper-statement basis.
Fixes #31602
Release note (enterprise change): Adds the option to supply Google Cloud
Storage credentials on a per-statement basis with the query parameter
credentials.