Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: add validation to cascading zone configs #32861

Merged
merged 3 commits into from
Dec 12, 2018
Merged

sql: add validation to cascading zone configs #32861

merged 3 commits into from
Dec 12, 2018

Commits on Dec 12, 2018

  1. sql: add COPY FROM PARENT command for zone configs 

    Adds a `COPY FROM PARENT` command to zone configs to
solidify a field. Solidifying a field means, the field will
now be explicitly set to the value that applied to it.
Any change to a parent zone on the field will no longer
affect it.
This change will allow people to do the following:

`ALTER .... CONFIGURE ZONE USING range_min_bytes = ...,
range_max_bytes = COPY FROM PARENT` instead of figuring
out what the `RangeMaxBytes`should be and populating it manually.
This change will allow us to add a validation constraint
that tandem fields are set together (for more details see
the cascading zone config RFC).

Release note (sql change): New SQL command added.
`ALTER ... CONFIGURE ZONE USING field_name = COPY FROM PARENT`
now solidifies/explicitly sets the field.
    Ridwan Sharif committed Dec 12, 2018
    Configuration menu
    Copy the full SHA
    666a458 View commit details
    Browse the repository at this point in the history

  2. config: Add zone validation for tandem fields 

    As described in the cascading zone RFC, a few additional
constraints are required on zone config usage so no zone
is ever in an invalid state if their parent zone changes
a value.

Release note: None
    Ridwan Sharif committed Dec 12, 2018
    Configuration menu
    Copy the full SHA
    5c2f145 View commit details
    Browse the repository at this point in the history

  3. sql: Update the zone specifier formatter 

    The formatter is updated to now recognise the COPY FROM PARENT
command when the value in the KVOption is nil.

Release note: None
    Ridwan Sharif committed Dec 12, 2018
    Configuration menu
    Copy the full SHA
    733cfb7 View commit details
    Browse the repository at this point in the history