pgwire: test \u0001 in JSON pgwire encoding #33222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Verify that we handle "\u0001" JSON strings identically to postgres. The printing of \u0001 instead of some other character is correct, and the same as what postgres does. (We do not test \u0000 here because postgres rejects it as a valid string, even though we accept it.) Closes #33165 Release note: None
|
This change is |
knz
approved these changes
Dec 18, 2018
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Dec 18, 2018
33221: sql: always use typed expressions for shift on int r=mjibson a=mjibson Previously the expressions 1 << 63 and 1::int << 63 would return positive and negative results, respectively. This was because constant folding in the first case is not subject to 2s complent that causes negative ints in the second case. Change shift on int to not fold. This prevents the surprising behavior described above in addition to other bugs where shifting by a large amount could allocate huge amounts of memory and crash the process. Fixes #32682 Release note (sql change): Shift operators on integers now always operate on explicit types instead of possibly an untyped constant. They also now return an error if the right-side operand is out of range. 33222: pgwire: test \u0001 in JSON pgwire encoding r=mjibson a=mjibson Verify that we handle "\u0001" JSON strings identically to postgres. The printing of \u0001 instead of some other character is correct, and the same as what postgres does. (We do not test \u0000 here because postgres rejects it as a valid string, even though we accept it.) Closes #33165 Release note: None Co-authored-by: Matt Jibson <matt.jibson@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verify that we handle "\u0001" JSON strings identically to postgres. The
printing of \u0001 instead of some other character is correct, and the
same as what postgres does. (We do not test \u0000 here because postgres
rejects it as a valid string, even though we accept it.)
Closes #33165
Release note: None