release-2.1: pgwire: detect, log, and immediately close any cancel requests #33246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the cmuxer would not detect pgwire cancel requests as pgwire and instead hand them off to GRPC causing them to hang. We still don't support cancel, but it should be handled better by clients now. Fixes #32973 Release note (bug fix): Cancel requests (via the pgwire protocol) will now close quickly with an EOF instead of hang (but still don't cancel the request).
|
This change is |
tbg
approved these changes
Dec 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #33202.
/cc @cockroachdb/release
Previously the cmuxer would not detect pgwire cancel requests as pgwire
and instead hand them off to GRPC causing them to hang. We still don't
support cancel, but it should be handled better by clients now.
Fixes #32973
Release note (bug fix): Cancel requests (via the pgwire protocol) will
now close quickly with an EOF instead of hang (but still don't cancel
the request).