Move MVCCKey encoding into C++. #3337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petermattis
force-pushed
the
pmattis/mvcc-key
branch
from
28a3311
to
3f77a1a
Compare
| @@ -125,6 +125,8 @@ message RaftSnapshotData { | |||
| message KeyValue { | |||
| optional bytes key = 1; | |||
| optional bytes value = 2; | |||
| optional int64 wall_time = 3 [(gogoproto.nullable) = false]; | |||
There was a problem hiding this comment.
Can we embed a roachpb.Timestamp here or does that add noticeable overhead?
There was a problem hiding this comment.
Probably. I had an import issue with the protos and meant to revisit this. I had used separate fields purely for expediency during development.
|
LGTM |
petermattis
force-pushed
the
pmattis/mvcc-key
branch
from
3f77a1a
to
ee5b8c1
Compare
Changed all of the Engine/Iterator interfaces to use MVCCKeys. Moving the MVCCKey encoding from Go to C++ simplifies the usage of MVCCKeys. The MVCCKey type is now a structure composed of a roachpb.Key and a timestamp. This is both more convenient to use and a minor perf win, though the motivation behind this change was to pave the way to using a custom RocksDB comparator. name old time/op new time/op delta MVCCScan1Version1Row8Bytes-8 4.70µs ± 2% 4.46µs ± 1% -5.01% (p=0.000 n=9+8) MVCCScan1Version10Rows8Bytes-8 23.7µs ± 1% 22.6µs ± 0% -4.95% (p=0.000 n=10+9) MVCCScan1Version100Rows8Bytes-8 200µs ± 1% 190µs ± 1% -4.81% (p=0.000 n=9+9) MVCCScan1Version1000Rows8Bytes-8 1.94ms ± 0% 1.85ms ± 0% -4.39% (p=0.000 n=9+10)
petermattis
force-pushed
the
pmattis/mvcc-key
branch
from
ee5b8c1
to
f5f0ead
Compare
petermattis
added a commit
that referenced
this pull request
Dec 9, 2015
Move MVCCKey encoding into C++.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed all of the Engine/Iterator interfaces to use MVCCKeys. Moving
the MVCCKey encoding from Go to C++ simplifies the usage of
MVCCKeys. The MVCCKey type is now a structure composed of a roachpb.Key
and a timestamp. This is both more convenient to use and a minor perf
win, though the motivation behind this change was to pave the way to
using a custom RocksDB comparator.