sql: stop returning dropped unique columns in DELETE RETURNING #33438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this change is a followup to fix cockroachdb#32188 unique columns have an index on them. When such a column is dropped, a DELETE statement will read a dropped column to correctly drop the index on it, but this dropped column is exposed through the RETURNING clause. This change stops exposing the column via RETURNING. fixes cockroachdb#33361 Release note (sql change): fixed problem with returning dropped unique columns in DELETE RETURNING statement.
|
This change is |
|
TFTR! |
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jan 3, 2019
33438: sql: stop returning dropped unique columns in DELETE RETURNING r=vivekmenezes a=vivekmenezes this change is a followup to fix #32188 unique columns have an index on them. When such a column is dropped, a DELETE statement will read a dropped column to correctly drop the index on it, but this dropped column is exposed through the RETURNING clause. This change stops exposing the column via RETURNING. fixes #33361 Release note (sql change): fixed problem with returning dropped unique columns in DELETE RETURNING statement. Co-authored-by: Vivek Menezes <vivek@cockroachlabs.com>
Build succeeded |
knz
moved this from Triage
to Monday pile
in (DEPRECATED) SQL Front-end, Lang & Semantics
knz
moved this from Monday pile
to Finished (m2.2-3)
in (DEPRECATED) SQL Front-end, Lang & Semantics
|
maybe this wants a backport? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this change is a followup to fix #32188
unique columns have an index on them. When such a column is dropped,
a DELETE statement will read a dropped column to correctly drop
the index on it, but this dropped column is exposed through the
RETURNING clause. This change stops exposing the column via RETURNING.
fixes #33361
Release note (sql change): fixed problem with returning dropped
unique columns in DELETE RETURNING statement.