sql: fix leak of prepared statements #33529
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The connExPrepStmtsAccessor.DeleteAll() method was not properly implemented and
"leaked" the memory accounting for prepared statements. This could lead
to crashes, like showed below.
I've looked at the various open issues around memory leak crashes, but
unfortunately I think it's unlikely this fixes those. Anyway, I'll
backport.
root@127.0.0.1:53405/defaultdb> begin; select 1;
root@127.0.0.1:53405/defaultdb OPEN> prepare x as select 1;
root@127.0.0.1:53405/defaultdb OPEN> deallocate all;
root@127.0.0.1:53405/defaultdb OPEN> commit;
root@127.0.0.1:53405/defaultdb> ^D
panic: session: unexpected 10240 leftover bytes
Release note (bug fix): Fix a memory leak around DEALLOCATE and DISCARD
statements that could result in crashes with the "unexpected
leftover bytes" message.