release-2.1: changefeedccl: fix bug with changefeeds on previously backfilled tables #34362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An internal sanity assertion was a bit overeager. It double-check that if a schema change backfill happened, that we've also done the changefeed backfill, but it was also triggering on schema change backfills that happened before the changefeed even started. Closes cockroachdb#34314 Release note (bug fix): `CHANGEFEED` now can be started on tables that have previously been backfilled by schema changes.
|
This change is |
nvanbenschoten
approved these changes
Jan 30, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #34317.
/cc @cockroachdb/release
Resolved small cherry-pick conflicts in helpers_test.go because an adjacent line had changed and in TestChangefeedAfterSchemaChangeBackfill because release-2.1 doesn't have rangefeedTest.
An internal sanity assertion was a bit overeager. It double-check that
if a schema change backfill happened, that we've also done the
changefeed backfill, but it was also triggering on schema change
backfills that happened before the changefeed even started.
Closes #34314
Release note (bug fix):
CHANGEFEEDnow can be started on tables thathave previously been backfilled by schema changes.