sql: increase max size of query in crash report #34479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's been frustrating seeing crashes with cut-off queries - there's no reason for the limit to be so low (500). This bumps it up by a lot. Release note (general change): incrase the maximum length of queries in crash reports, to make debugging easier.
|
This change is |
tbg
approved these changes
Feb 1, 2019
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @tbg)
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Feb 1, 2019
34479: sql: increase max size of query in crash report r=jordanlewis a=jordanlewis It's been frustrating seeing crashes with cut-off queries - there's no reason for the limit to be so low (500). This bumps it up by a lot. Release note (general change): incrase the maximum length of queries in crash reports, to make debugging easier. Co-authored-by: Jordan Lewis <jordanthelewis@gmail.com>
Build succeeded |
|
Going through Marvin's digest I saw a type in release note here: |
|
Oops - thanks Yahor. Fixed. |
|
Haha, I just noticed that I had a typ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been frustrating seeing crashes with cut-off queries - there's no
reason for the limit to be so low (500). This bumps it up by a lot.
Release note (general change): increase the maximum length of queries in
crash reports, to make debugging easier.