Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GROUP BY implementation #3494

Merged
merged 4 commits into from
Dec 29, 2015
Merged

GROUP BY implementation #3494

merged 4 commits into from
Dec 29, 2015

Commits on Dec 26, 2015

  1. aggregate impl map: switch instances to funcs 

    Also un-export impl methods.
    @dt
    dt committed Dec 26, 2015
    Configuration menu
    Copy the full SHA
    5b3c6f8 View commit details
    Browse the repository at this point in the history

  2. pull encode DTuple out into own helper

    @dt
    dt committed Dec 26, 2015
    Configuration menu
    Copy the full SHA
    7e99b72 View commit details
    Browse the repository at this point in the history

  3. normalize group-by expressions to match render expressions

    @dt
    dt committed Dec 26, 2015
    Configuration menu
    Copy the full SHA
    91de209 View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2015

  1. GROUP BY implementation 

    Add buckets of values to aggregateFuncs, and capture grouped qvalues.
Render buckets into rows of a valuesNode on first call to Next.

Note: ORDER BY (with GROUP BY) still unsupported (as is HAVING).
    @dt
    dt committed Dec 29, 2015
    Configuration menu
    Copy the full SHA
    c12a685 View commit details
    Browse the repository at this point in the history