Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transient stats prototype #3504

Merged
merged 1 commit into from
Dec 30, 2015
Merged

transient stats prototype #3504

merged 1 commit into from
Dec 30, 2015

Commits on Dec 30, 2015

  1. transient stats prototype

    This is a prototype for the collection of transient performance statistics.
    It does not yet expose "useful" runtime statistics, but is meant to lay the
    groundwork for doing so across different parts of the system.
    
    We were previously using the `go-metrics` package, which provides the concept
    of a `Registry` bundling different metrics. Unfortunately, various limitations,
    a certain amount of interface bloat (which made it annoying to provide custom
    implementations) and various design choices made this unwieldy to work with
    without upstream adaptations.
    Instead, introduced the `util/metric` package which replaces the registry
    functionality and provides light wrapper implementations around metrics.
    
    Metric registries can be nested and in fact we do so, keeping one "global"
    metrics registry and various others in it. In particular Node- and Store-level
    metrics have individual registries. This is useful since this allows their
    metrics to be stored to their corresponding time series with simple iterations
    over a registry and with correct names globally and locally.
    
    For now, we wrap `Counter`, `Gauge` and `EWMA` types and provide a windowed
    histogram (based on Gil Tene's `HDRHistogram`s). Others (such as reservoir
    backed histograms can be added as required.
    tbg committed Dec 30, 2015
    Configuration menu
    Copy the full SHA
    3a82c69 View commit details
    Browse the repository at this point in the history