sql: accept floats when expecting ints during logic tests

[maddyblue]

fixes #3271

[tamird]

This isn't quite enough; i was playing with adding the logic tests enabled by GROUP BY support (#3494) and found for example: SELECT DISTINCT 20 / - 97 FROM tab0 which expects "0" but gets "0.20...". We'll need to convert these floats to integers in this special case.

[tamird]

Actually, even that doesn't work, because of cases like SELECT DISTINCT col1 / 2 FROM tab1 where col1 is an integer; this query will not behave correctly with respect to DISTINCT.

[bdarnell]

What special case, exactly? Are you suggesting that DISTINCT int / int should convert the result to an int, but int / int in other cases should return a float? That seems like a bad idea to me.

The fact that SELECT DISTINCT 20 / - 97 FROM tab0 returns different results for us than it does in other databases is a simple consequence of the fact that we have chosen to have integer division return floats rather than ints; we expect and accept that this decision will not be 100% compatible.

[tamird]

Yes, feel free to ignore the first of my two comments. We will need to either accept this incompatibility and simply skip or massage offending test cases, or else revert to integer division.

[petermattis]

LGTM

---

Review status: 0 of 1 files reviewed at latest revision, all discussions resolved.

---

Comments from the review on Reviewable.io

[maddyblue]

We decided to use another solution. Closing.