storage: fix TestRangeInfo flake and re-enable follower reads by default #35793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
ajwerner
force-pushed
the
ajwerner/reenable-follower-reads
branch
from
35901cd
to
d441ad1
Compare
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @ajwerner and @nvanbenschoten)
pkg/storage/client_replica_test.go, line 1606 at r1 (raw file):
t.Fatal(pErr) } lhsLease, _ = lhsReplica1.GetLease()
Would an alternative be to change these to lhsReplica0.GetLease() and rhsReplica0.GetLease()?
pkg/storage/client_replica_test.go, line 1609 at r1 (raw file):
// triggered above. This is to protect against the case where the lease // transfer is applied on replica0 but not on replica1 at the time of the // above query. In this scenario replica0 can serve a follower read which
"which" what?
This PR addresses a test flake introduced by enabling follower reads in conjunction with cockroachdb#35130 which makes follower reads more generally possible in the face of lease transfer. Fixes cockroachdb#35758. Release note: None
ajwerner
force-pushed
the
ajwerner/reenable-follower-reads
branch
from
d441ad1
to
16fb58b
Compare
ajwerner
commented
Mar 16, 2019
There was a problem hiding this comment.
Reviewable status:
pkg/storage/client_replica_test.go, line 1606 at r1 (raw file):
Previously, nvanbenschoten (Nathan VanBenschoten) wrote…
Would an alternative be to change these to
lhsReplica0.GetLease()andrhsReplica0.GetLease()?
Yes, done.
nvanbenschoten
approved these changes
Mar 18, 2019
|
bors r+ |
Build failed |
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Mar 18, 2019
35284: storage,kv: make transaction deadline exceeded errors retriable r=andreimatei a=andreimatei Before this patch, they were opaque TransactionStatusErrors. The belief is that we should only be seeing such errors when a transaction is pushed by minutes. Shockingly, this seems to hapen enough in our tests, for example as described here: #18684 (comment) This patch marks the error as retriable, since it technically is. This patch also changes the semantics of the EndTransactionRequest.Deadline field to make it exclusive so that it matches the nature of SQL leases. No migration needed. Touches #18684 Release note (sql change): "transaction deadline exceeded" errors are now returned to the client with a retriable code. 35793: storage: fix TestRangeInfo flake and re-enable follower reads by default r=ajwerner a=ajwerner This PR addresses a test flake introduced by enabling follower reads in conjunction with #35130 which makes follower reads more generally possible in the face of lease transfer. Fixes #35758. Release note: None 35865: roachtest: Skip flaky jepsen nemesis r=tbg a=bdarnell See #35599 Release note: None Co-authored-by: Andrei Matei <andrei@cockroachlabs.com> Co-authored-by: Andrew Werner <ajwerner@cockroachlabs.com> Co-authored-by: Ben Darnell <ben@bendarnell.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a test flake introduced by enabling follower reads in
conjunction with #35130 which makes follower reads more generally possible
in the face of lease transfer.
Fixes #35758.
Release note: None