Commits on Apr 16, 2019

1. sql: fix multiple UX shortcomings with zone configs …

   This patch resolves several separate but related SQL zone config bugs.
   
   1. SHOW ZONE CONFIG would print out nonsensical ALTER statements
      for inherited database zone configs or the default zone config.
   
      This was happening because of a conjunction of two implementations
      shortcuts:
   
      - `(*ZoneSpecifier).Format()` would print out the "PARTITION"
        keyword as soon as the partition name was set, even for zone
        specifiers for ranges or databases (only tables or indexes can
        have partitions). This is nonsensical.
   
      - the code for SHOW ZONE CONFIG would determine a zone specifier
        to use for the output ALTER syntax by filling fields from
   	 the resolved zone details *on top* of the initial zone specifier.
   	 So when doing SHOW ZONE CONFIG FOR PARTITION ..., *and*
   	 there was no zone config for that partition (so that a database
   	 or range config would apply), the resulting zone specifier
   	 would still have its "Partition" field populated.
   
      This patch fixes the issue by both omitting the PARTITION clause
      for non-table, non-index zone specifiers, and erasing the partition
      field in the ALTER zone specifier in SHOW ZONE CONFIG.
   
   2. parser does not recognize ALTER syntax printed by SHOW ZONE CONFIG.
   
      When using SHOW ZONE CONFIG on a partitioned index, the output
      ALTER syntax printed by SHOW would say `ALTER PARTITION ... OF
      INDEX tbl@idx  CONFIGURE ZONE ...`.
   
      However, the SQL grammar did not recognize `ALTER PARTITION OF
      INDEX`, resulting in poor UX. This patch adds support for the
      missing syntax.
   
   3. SHOW ZONE CONFIG would accept but *ignore* a partition name
      specifier when using the syntax variant `... FOR TABLE
      ... PARTITION ...`. (The partition name was properly handled when
      using the variant `... FOR PARTITION ... OF TABLE ...`).
   
      This was causing suprising/incorrect results when using that
      syntax (especially when combined with the first two bugs).
   
      This patch ensures that the partition name is not ignored in this form.
   
   4. SHOW ZONE CONFIG would accept two (equivalent) syntax forms for
      partitioned tables, but just one for indexes. This was
      inconsistent.
   
      This patch ensures that both the forms `FOR INDEX ... PARTITION
      ... ` and `FOR PARTITION ... OF INDEX ...` are supported,f or
      consistency.
   
   Release note (bug fix): `SHOW ZONE CONFIGURATION` does not any more
   emit invalid ALTER syntax in its output when displaying the zone
   configuration for a table or index partition that is inheriting from
   the database or the default configuration.
   
   Release note (enterprise change): It is now possible to alter the zone
   configuration for a secondary index partition using the syntax `ALTER
   PARTITION OF INDEX <tablename>@<indexname> CONFIGURE ZONE ...`.
   
   Release note (bug fix): `SHOW ZONE CONFIGURATION FOR TABLE t PARTITION
   p` does not ignore the clause "PARTITION p" any more and properly
   displays the zone configuration for that partition instead.

   

   knz committed Apr 16, 2019
   Copy the full SHA

   9802577 View commit details

   Browse the repository at this point in the history