release-19.1: opt, sql: fix type inference of TypeCheck for subqueries #37598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
RaduBerinde
approved these changes
May 20, 2019
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @jordanlewis, @justinj, and @RaduBerinde)
rytaft
force-pushed
the
backport19.1-37578
branch
from
c0af4f0
to
7d22d10
Compare
Prior to this commit, the optimizer was not correctly inferring the types of
columns in subqueries for expressions of the form `scalar IN (subquery)`.
This was due to two problems which have now been fixed:
1. The subquery was built as a relational expression before the desired types
were known. Now the subquery build is delayed until TypeCheck is called for
the first time.
2. For subqueries on the right side of an IN expression, the desired type
passed into TypeCheck was FamTuple. This resulted in an error later on in
typeCheckSubqueryWithIn, which checks to make sure the type of the subquery
is tuple{T} where T is the type of the left expression. Now the desired
type passed into TypeCheck is tuple{T}.
Note that this commit only fixes type inference for the optimizer. It is still
broken in the heuristic planner.
Fixes cockroachdb#37263
Fixes cockroachdb#14554
Release note (bug fix): Fixed type inference of columns in subqueries for
some expressions of the form `scalar IN (subquery)`.
rytaft
force-pushed
the
backport19.1-37578
branch
from
7d22d10
to
3c5e7b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #37578.
/cc @cockroachdb/release
Prior to this commit, the optimizer was not correctly inferring the types of
columns in subqueries for expressions of the form
scalar IN (subquery).This was due to two problems which have now been fixed:
The subquery was built as a relational expression before the desired types
were known. Now the subquery build is delayed until
TypeCheckis called forthe first time.
For subqueries on the right side of an
INexpression, the desired typepassed into
TypeCheckwasAnyTuple. This resulted in an error later on intypeCheckSubqueryWithIn, which checks to make sure the type of the subqueryis
tuple{T}whereTis the type of the left expression. Now the desiredtype passed into
TypeCheckistuple{T}.Note that this commit only fixes type inference for the optimizer. It is still
broken in the heuristic planner.
Fixes #37263
Fixes #14554
Release note (bug fix): Fixed type inference of columns in subqueries for
some expressions of the form
scalar IN (subquery).