release-2.1: c-deps: bump rocksdb to pick up iterator fix #37694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bug caused us to miss a key if the scan was second or later in a batch of scans, the previous scan had gone past its upper bound, and the scan's target key landed in the gap between two files bridged by a range tombstone. There may be other cases this fixes with using an iterator to scan backwards after using it to scan forwards, though we haven't observed those cases. Release note: Fixed possible row missing from queries that involved iterator reuse and seeking into the gap between sstables bridged by a range tombstone.
|
This change is |
bdarnell
approved these changes
May 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug caused us to miss a key if the scan was second or later in a
batch of scans, the previous scan had gone past its upper bound, and the
scan's target key landed in the gap between two files bridged by a range
tombstone. There may be other cases this fixes with using an iterator to
scan backwards after using it to scan forwards, though we haven't
observed those cases.
PR this picks up: cockroachdb/rocksdb#31
Fixes #37516.
Release note: Fixed possible row missing from queries that involved
iterator reuse and seeking into the gap between sstables bridged by a
range tombstone.